-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI changes corresponding to #1038 #1039
Conversation
chat widget displayed above the "blocking div" (When in observer mode)
reset to defaults (as redux persist was removed)
previously missing the first element (index 0)
…olors from green to cyan
3e90653
to
472ac63
Compare
6499d35
to
f7d4ff6
Compare
return [ | ||
makeLine( | ||
10, | ||
height - 10, | ||
scaleLengthX + 10, | ||
height - 10, | ||
'green', | ||
'rgba(0, 255, 255, 1)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally ignorant of context here, but it looks like hardcoding rgb values in code, as opposed to using some kind of symbol, This presumably has been considered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
green
is just an alias in this library (CSS/HTML for a green color) and in this library fabric.js
for rgba(0, 255, 0)
so there is no difference really. At least with rgb
I know more or less which color that is meant :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are very interested https://en.wikipedia.org/wiki/Web_colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
f7d4ff6
to
fdc42a5
Compare
) | ||
.then((response) => response.json()) | ||
.then((data) => { | ||
window.open( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment one needs to have braggy
for this feature, but it could be made configurable if needed
) : null} | ||
</div> | ||
</Draggable> | ||
<div className="chat-widget-dragable"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure that the chat widget is displayed on top of "the blocking div (for observer mode)"
@@ -47,12 +47,12 @@ export class TaskItem extends React.Component { | |||
|
|||
break; | |||
} | |||
case 'XRFScan': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply a name change
@@ -225,6 +225,9 @@ export default class DrawGridPlugin { | |||
* @param {float} y - bottom y coordinate of grid, (mouse y position) | |||
*/ | |||
update(canvas, x, y) { | |||
this.gridData.screenCoord[0] = this.currentTopLeftX; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure that the grid coordinates are not being updated on accidental clicks (after being drawn but not saved)
@@ -266,7 +266,7 @@ export default class SampleControls extends React.Component { | |||
className="bar" | |||
type="range" | |||
id="zoom-control" | |||
min={zoom_motor.limits[0]} | |||
min={zoom_motor.limits[0] - 1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure the first zoom level is available index 0 :)
@@ -165,8 +167,12 @@ export default class SampleImage extends React.Component { | |||
|
|||
onMouseMove(options) { | |||
if (this.props.clickCentring && this.props.clickCentringClicksLeft > 0) { | |||
if (this.centringVerticalLine !== undefined) { | |||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drawing both horizontal and vertical lines (as we used to do)
@@ -15,6 +15,9 @@ import { | |||
FieldsRow, | |||
CollapsableRows, | |||
toFixed, | |||
getLastUsedParameters, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a simply functionality to "remember" (store dialog values in local storage) as redux-persist
was removed. The general plan is to simplify the overall state management and also replace the redux-form
based dialogs with something simpler and better maintained. So this local storage solution with getLastUsedParamters
is an intermediate solution.
I cannot have a meaningful opinion on these changes, so no review from me. Thanks for the explanatory comments, btw, they are very useful. |
ed09ae9
to
b0587b2
Compare
b0587b2
to
2e9607e
Compare
f17f93f
to
05df2c3
Compare
Changes to the UI that goes with changes in #1038
redux-local-storage
was removed)(The dialog code will be rewritten and the
redux-form
dependency removed in a following PR)PopInput